sifatbaho/backend-v1
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: add 404 response for missing company or person in Didox API

Browse Source
This commit is contained in:
komoliddin
2026-04-22 11:28:35 +05:00
parent cb2d83b00d
commit 01711b5927
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/apps/evaluation/views/didox.py
View File

@@ -31,7 +31,6 @@ class DidoxCompanyInfoAPIView(GenericAPIView):
def get(self, request, *args, **kwargs): def get(self, request, *args, **kwargs):
tin = kwargs.get("tin") tin = kwargs.get("tin")
# 🔥 TYPE CHECK
try: try:
tin = int(tin) tin = int(tin)
except (TypeError, ValueError): except (TypeError, ValueError):
@@ -48,4 +47,14 @@ class DidoxCompanyInfoAPIView(GenericAPIView):
status=status.HTTP_502_BAD_GATEWAY status=status.HTTP_502_BAD_GATEWAY
) )
# if both name and personalNum are null/empty -> 404
name = data.get("name")
personal_num = data.get("personalNum")
if not name and not personal_num:
return Response(
{"detail": "Company or person not found"},
status=status.HTTP_404_NOT_FOUND
)
return Response(data, status=status.HTTP_200_OK) return Response(data, status=status.HTTP_200_OK)